Discussion
FB3 Beta 10(back to index)As the fb3b08 thread has grown rather long (that's what I get for programming at 4am), please post version 10 discussion here. You'll want to read the
release notes for version 08 and 09 if you haven't yet.
Let me know what bugs you find, et cetera.
posted by
donald on 7 Jul 05 at 2:45 PM
Small thing:
Line 319 should be:
$message = "Please set a password in fb_settings.php.";
Big thing:
I still can't delete checked comments in post mode.
Other than that, it seems to work just fine. I'll keep on trying to break it, though ;-)
posted by
Elwing on 7 Jul 05 at 3:37 PM
Can't delete checked comments too. The rest looks great. :)
posted by
jowra on 7 Jul 05 at 4:10 PM
Another small thing:
Line 232 of fb.php has this on the end:
"/comments/\n\n(You can disable this feature in your folderblog's vars.php.)"
That should be:
"/comments/\n\n(You can disable this feature in your folderblog's settings.php.)"
or something like that. Also, those users of templates that don't have a 'template_comments.php' file might want to delete the "/comments/" bit from the start of that line (this would be a hack, as it works fine for the default template).
posted by
Elwing on 7 Jul 05 at 5:18 PM
Thanks Elwing and jowra. Should all be square now (fb3b11.zip). The action of all forms should point to <#fbself#>, and I finally snagged the comment deletion bug.
By the way, you can enqueue files via your /post/ page by setting the timestamp to a future time at which you want the file to be posted.
Let me know if you find any other bugs, have any additional suggestions, et cetera.
posted by
donald on 7 Jul 05 at 8:29 PM
I'm not sure about this, but it looks like no matter what date/time stamp you set in post mode, it gets set to the present date/time. It might just happen if you try to change it, or it may happen if you simply hit Update. I tried to set a date in the past, and it set it to the present.
Other than that, this build seems to work superbly!
posted by
Elwing on 7 Jul 05 at 10:28 PM
Not sure why you'd get that bug, Elwing, unless your touching isn't working right. It works in the demo blog, and the code is pretty straightforward — anyone else having similar problems?
posted by
donald on 7 Jul 05 at 11:31 PM
Elwing, when you swap the categories a photo belongs to (without touching the date field), does the photo get bumped to the top of the sort order?
posted by
donald on 7 Jul 05 at 11:46 PM
Works perfect for me. When I change the filedate of the newest image it jumps 'back in time'. :-)
Can't see any other problems for now. The only thing I didn't tested were the categories. ;-)
Great Job and great new version Donald!
posted by
jowra on 8 Jul 05 at 3:33 AM
Just posted fb3b12. A handful of bugfixes (including important fixes to the RSS feed and category system).
posted by
donald on 8 Jul 05 at 4:35 AM
when you post a comment and you include a link inside your comment (html formated) and then continue writing your comment, the comment will be post in two part try it at home see the result at http://kikiweb.altervista.org/fb.php/Monchhichi_DJ/Dscn0045/
posted by
kiki on 8 Jul 05 at 7:31 AM
Just an idea: I've just manually changed all date()-functions to strftime() (as in the previous betas too). With the setlocale(LC-TIME, "languagecode") command every user could then set the date-/timeformat to his national conventions (e.g. using the right names for weekdays and month).
Not really a big issue, I know. :)
posted by
jowra on 8 Jul 05 at 11:18 AM
Donald, not sure what you're asking me to do there. What I did was, on a selected image, uncheck a box for one category and check another category box. Nothing happened, except the date was set to the present (I didn't touch that input field). I also tried to select two categories, but the same thing happened. Obviously, I didn't actually move the large image from it's category directory (and I used the 'category.txt' files to name them). I'm not using the 0-byte files, either. It seems that post mode won't let you alter the category an image is in, and it changes the date stamp of the image file to the present whenever you hit Update.
Kiki, I added a comment with an HTML
tag in it, and the result was that it treated the whole comment as plain text (i.e. it didn't render the HTML). You can see the result
here.
posted by
Elwing on 8 Jul 05 at 11:24 AM
Sorry for the comment on your page... but each times you hit enter and you start a new phrase it's generate a new comment. If you write 10 lines with 10cariage return you will have 10comment and not one!
posted by
kiki on 8 Jul 05 at 11:50 AM
Thanks for the heads-up on the bug, kiki. It's been fixed with fb3b13.
This latest release also implements jowra's suggested use of strftime (for language specific dates) as well as a $time_difference variable in case your server resides in a different time zone than you.
posted by
donald on 8 Jul 05 at 1:13 PM
Elwing, can you create a file with the following text and tell me the output? Put in a directory that has been chmod'ed to at least 755.
<?php
error_reporting(E_ALL);
$file = fopen("test.txt", "w");
fclose($file);
if(!file_exists("test.txt")) echo "Create failed.<br />";
touch("test.txt",strtotime("June 22, 2002"));
echo "Date: " . date("F j, Y",filemtime("test.txt")) . "<br />";
unlink("test.txt");
clearstatcache();
if(file_exists("test.txt")) echo "Unlink failed";
?>
posted by
donald on 8 Jul 05 at 1:22 PM
The output of the above file is "Date: June 22, 2002
" on a directory set to chmod 777.
posted by
Elwing on 8 Jul 05 at 7:28 PM
Elwing, this is quite perplexing then. Your server's touch() function is working as expected, and it seems to have no problem creating/deleting files — so I'm really at a loss to why it would mis-set the date.
posted by
donald on 8 Jul 05 at 7:37 PM
Elwing, can you try a default install without fotobuzz? It's a long shot, but I'm wondering if fotobuzz is somehow modifying the files...
posted by
donald on 8 Jul 05 at 7:48 PM
Nope, the same thing happens without FotoBuzz.
posted by
Elwing on 9 Jul 05 at 10:44 AM
Elwing, this one's killer — I'm really running out of ideas.
One last thing to try: add this code to the top of your template, then try to change a file's date to a random date in the past few years. There should be a few lines output after you've done the post. Let me know the output.
<?php
if(get("doPost")) {
echo "Timestamp: " . date("Y-m-d H:i:s",$timestamp) . " ($timestamp)<br />";
echo "get(timestamp): " . get("timestamp") . " (" . strtotime(get("timestamp")) . ")<br />";
$timestamp = strtotime("June 22, 2002");
echo "June22: " . date("Y-m-d", $timestamp) . "<br />";
}
?>
posted by
donald on 10 Jul 05 at 5:00 AM
Some example outputs:
Timestamp: 2005-06-24 19:04:35 (1119654275)
get(timestamp): 2005-06-24 19:04:35 (1119654275)
June22: 2002-06-22
Timestamp: 2003-05-12 16:30:42 (1052771442)
get(timestamp): 2003-05-12 16:30:42 (1052771442)
June22: 2002-06-22
Regardless, <#fbdate#> reports the present date, and the image is bumped to the top (most recent) entry, with chmod 777 on everything that could possibly be written to. This happens regardless of template, with or without FotoBuzz.
There might be something odd about my server. Things seem to change there fairly often, as the tech boys tinker, and it's one of those servers that runs PHP in Safe Mode. A few weeks ago, it was running PHP 5.x with only a few extensions compiled, and now it's back on PHP 4.3.11 with PEAR and Exif (and all sorts of other stuff) compiled. If it's helpful, there's the
phpinfo() output.
posted by
Elwing on 10 Jul 05 at 11:51 AM
Elwing, thanks for all the help trying to snag this one. What's really perplexing is that the touch() function seems to work fine on your server (the July 8th code), and the timestamp seems to be registering fine: it's just a question of why they don't work out together.
posted by
donald on 10 Jul 05 at 6:15 PM
Post a Reply:
(back to index)